turned quote rule into enumeration + minor formatting improvements #7222

badasahog · 2025-07-28T17:03:26Z

No description provided.

aitap · 2025-07-28T17:14:58Z

You seem to have started from an earlier master, before #7214 and #7205, because this PR reverts them. On the other hand, your branch stems from cfa9f49 (which is master as of time of writing). Did a merge go wrong? Maybe we can help you fix your process?

codecov · 2025-07-28T17:15:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (b596eb1) to head (6f81163).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7222   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          81       81           
  Lines       15241    15241           
=======================================
  Hits        15055    15055           
  Misses        186      186

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

badasahog · 2025-07-28T17:16:12Z

yikes, I know exactly what happened. Didn't realize this file was being played with.

github-actions · 2025-07-28T17:21:39Z

HEAD=quoteRuleEnumeration slower P<0.001 for memrecycle regression fixed in #5463
HEAD=quoteRuleEnumeration slower P<0.001 for setDT improved in #5427

Generated via commit 6f81163

Download link for the artifact containing the test results: ↓ atime-results.zip

Task	Duration
R setup and installing dependencies	2 minutes and 36 seconds
Installing different package versions	38 seconds
Running and plotting the test cases	2 minutes and 29 seconds

src/fread.c

Co-authored-by: Michael Chirico <[email protected]>

…data.table into quoteRuleEnumeration

turned quote rule into enumeration + minor formatting improvements

13d9b50

badasahog requested a review from aitap as a code owner July 28, 2025 17:03

updated comments

dea68c1

restored overridden changes

067bab1

MichaelChirico reviewed Jul 28, 2025

View reviewed changes